Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed resolving Selection1D in bokeh callback #2586

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Conversation

philippjfr
Copy link
Member

In bokeh 0.12.15 the selection API was changed introducing a dedicated Selection model. This PR ensures that the 1D indices are correctly resolved in bokeh server mode.

  • Re-added unit test

@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: backend: bokeh labels Apr 20, 2018
@philippjfr
Copy link
Member Author

Ready to merge.

@jlstevens
Copy link
Contributor

Looks good. Merging.

@jlstevens jlstevens merged commit 6a98f62 into master Apr 20, 2018
@philippjfr philippjfr deleted the server_selection1d branch July 4, 2018 11:15
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tag: backend: bokeh type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants